fixed as per review comments

istio-ecosystem · Aug 22, 2024 · e052c31 · e052c31
1 parent e8d4d65
commit e052c31
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/admiral/pkg/clusters/serviceentry.go b/admiral/pkg/clusters/serviceentry.go
@@ -55,7 +55,7 @@ const (
 	gtpManagedByMeshAgent                        = "mesh-agent"
 	gtpManagerMeshAgentFieldValue                = "ewok-mesh-agent"
 	errorCluster                                 = "error-cluster"
-	ingressVSGenerationErrorMessage              = "skipped generating ingress virtual service due to error "
+	ingressVSGenerationErrorMessage              = "skipped generating ingress virtual service on cluster %s due to error %w"
 )
 
 func createServiceEntryForDeployment(
@@ -296,7 +296,7 @@ func modifyServiceEntryForNewServiceOrPod(
 			if common.IsVSBasedRoutingEnabled() {
 				err := generateIngressVirtualServiceForDeployment(deployment, sourceIngressVirtualService)
 				if err != nil {
-					err = fmt.Errorf(ingressVSGenerationErrorMessage + " w%" + err.Error())
+					err = fmt.Errorf(ingressVSGenerationErrorMessage, clusterId, err)
 					ctxLogger.Errorf(common.CtxLogFormat, "generateIngressVirtualServiceForDeployment",
 						deployment.Name, deployment.Namespace, clusterId, err.Error())
 					modifySEerr = common.AppendError(modifySEerr, err)
@@ -356,7 +356,7 @@ func modifyServiceEntryForNewServiceOrPod(
 			if common.IsVSBasedRoutingEnabled() {
 				err := generateIngressVirtualServiceForRollout(rollout, sourceIngressVirtualService)
 				if err != nil {
-					err = fmt.Errorf(ingressVSGenerationErrorMessage + " w%" + err.Error())
+					err = fmt.Errorf(ingressVSGenerationErrorMessage, clusterId, err)
 					ctxLogger.Errorf(common.CtxLogFormat, "generateIngressVirtualServiceForRollout",
 						rollout.Name, rollout.Namespace, clusterId, err.Error())
 					modifySEerr = common.AppendError(modifySEerr, err)