Return error when failed to type cast.

istio-ecosystem · Sep 12, 2024 · 232eeb1 · 232eeb1
1 parent 61b23e8
commit 232eeb1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/admiral/pkg/controller/admiral/job.go b/admiral/pkg/controller/admiral/job.go
@@ -209,7 +209,7 @@ func (d *JobController) Updated(ctx context.Context, obj interface{}, oldObj int
 func addUpdateJob(j *JobController, ctx context.Context, obj interface{}) error {
 	job, ok := obj.(*v12.Job)
 	if !ok {
-		return nil
+		return fmt.Errorf("failed to covert informer object to Job")
 	}
 	if !common.ShouldIgnore(job.Annotations, job.Labels) {
 		k8sObj := j.Cache.getK8sObjectFromJob(job)

diff --git a/admiral/pkg/controller/admiral/monovertex.go b/admiral/pkg/controller/admiral/monovertex.go
@@ -208,7 +208,7 @@ func (d *MonoVertexController) Updated(ctx context.Context, obj interface{}, old
 func addUpdateMonoVertex(j *MonoVertexController, ctx context.Context, obj interface{}) error {
 	monoVertex, ok := obj.(v1alpha1.MonoVertex)
 	if !ok {
-		return nil
+		return fmt.Errorf("failed to covert informer object to MonoVertex")
 	}
 	if !common.ShouldIgnore(monoVertex.Annotations, monoVertex.Labels) {
 		k8sObj := j.Cache.getK8sObjectFromMonoVertex(monoVertex)

diff --git a/admiral/pkg/controller/admiral/vertex.go b/admiral/pkg/controller/admiral/vertex.go
@@ -208,7 +208,7 @@ func (d *VertexController) Updated(ctx context.Context, obj interface{}, oldObj
 func addUpdateVertex(j *VertexController, ctx context.Context, obj interface{}) error {
 	vertex, ok := obj.(v1alpha1.Vertex)
 	if !ok {
-		return nil
+		return fmt.Errorf("failed to covert informer object to Vertex")
 	}
 	if !common.ShouldIgnore(vertex.Annotations, vertex.Labels) {
 		k8sObj := j.Cache.getK8sObjectFromVertex(vertex)