adds unspent notes count to wallet balance rpc, cli #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates the available balance calculation to also count the number of unspent notes returns the unspent note count as 'availableNoteCount' from getBalance and getBalances updates rpc responses for wallet/getBalance and wallet/getBalances to return availableNoteCount updates wallet:balance and wallet:balances to display available note count when --explain and --all flags are used
NullSoldier
approved these changes
Jun 6, 2024
|
This PR does require documentation change to add this to the RPC docs on our website or it won't show the new field in the example response. |
Documentation changes here: iron-fish/website#705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updates the available balance calculation to also count the number of unspent notes
returns the unspent note count as 'availableNoteCount' from getBalance and getBalances
updates rpc responses for wallet/getBalance and wallet/getBalances to return availableNoteCount
updates wallet:balance and wallet:balances to display available note count when --explain and --all flags are used
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.