Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert to peer schema with multiple protocols #185

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: convert to peer schema with multiple protocols #185

merged 2 commits into from
Apr 23, 2024

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented Apr 23, 2024

Makes the /routing/v1/providers endpoint comply with the Peer Schema: https://specs.ipfs.tech/routing/http-routing-v1/#peer-schema

I changed all the current providers since they're all technically peers. Also note that I changed the protocol string to an array since we now send all protocols for the same peer in the same record. The metadata is implemented per protocol, hence a custom MarshalJSON.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 7.21%. Comparing base (1298b7d) to head (6d44b74).
Report is 2 commits behind head on main.

Files Patch % Lines
delegated_translator.go 0.00% 30 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #185      +/-   ##
========================================
+ Coverage   6.66%   7.21%   +0.54%     
========================================
  Files         11      11              
  Lines       1380    1165     -215     
========================================
- Hits          92      84       -8     
+ Misses      1281    1074     -207     
  Partials       7       7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masih masih merged commit bf104cf into ipni:main Apr 23, 2024
9 checks passed
masih added a commit to ipni/storetheindex that referenced this pull request Apr 23, 2024
masih added a commit to ipni/storetheindex that referenced this pull request Apr 23, 2024
masih added a commit to ipni/storetheindex that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants