Support multiple metadata transport protocols #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gammazero I think this PR would make #196 redundant if it only contains multi metadata support |
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 38.17% 39.15% +0.97%
==========================================
Files 49 53 +4
Lines 3526 3678 +152
==========================================
+ Hits 1346 1440 +94
- Misses 1929 1973 +44
- Partials 251 265 +14
|
masih
force-pushed
the
masih/metadata-api-mv
branch
from
7990a6f
to
cbbadeb
Compare
gammazero
reviewed
Mar 15, 2022
masih
force-pushed
the
masih/metadata-api-mv
branch
from
cbbadeb
to
c0c8376
Compare
Introduce the `Transport` type to capture information about multiple transport protocols within a single metadata. Re implement `Metadata` type to accommodate: * multiple transport protocols * enforce they are sorted by their ID * backward compatibility with existing metadata format * deserialization of existing formats gracefully. Add metadata conversion to keep code compiling until this PR is merged: - ipni/storetheindex#250 Fixes: #188
masih
force-pushed
the
masih/metadata-api-mv
branch
from
c0c8376
to
bf3ee40
Compare
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Mar 15, 2022
Remove the `v0.Metadata` type in favour of a simpler `[]byte` in preparation for moving all metadata types entirely to index provider. From this point onwards, metadata is treated as an opaque payload by the indexer. Users should use index-provider library to decode it instead. Relates to: - ipni/index-provider#198
|
Marking as draft until this is merged: ipni/storetheindex#260 |
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Mar 16, 2022
Remove the `v0.Metadata` type in favour of a simpler `[]byte` in preparation for moving all metadata types entirely to index provider. From this point onwards, metadata is treated as an opaque payload by the indexer. Users should use index-provider library to decode it instead. Relates to: - ipni/index-provider#198
masih
force-pushed
the
masih/metadata-api-mv
branch
from
a263fb5
to
e36b55b
Compare
gammazero
approved these changes
Mar 16, 2022
| Usage: "Specify retrieval protocol ID", | ||
| Required: true, | ||
| }, | ||
| metadataFlag, |
There was a problem hiding this comment.
This is fine for now, but we may want to have a graphsync and a bitswap flag to allow the user to specify the metadata protocol and contents.
Depend on head of PR that removes `Metadata` type in storetheindex so that we can remove all workarounds: - ipni/storetheindex#260
masih
force-pushed
the
masih/metadata-api-mv
branch
from
e36b55b
to
ead079b
Compare
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Mar 16, 2022
This reverts commit 537eb37 now that the index-provider is upgraded. See: - ipni/index-provider#198
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Mar 16, 2022
This reverts commit 537eb37 now that the index-provider is upgraded. See: - ipni/index-provider#198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
Transporttype to capture information about multipletransport protocols within a single metadata.
Re implement
Metadatatype to accommodate:Add metadata conversion to keep code compiling until this PR is merged:- ipni/storetheindex#250The PR now depends on the head of sti
mainnow that this PR is merged.Fixes: #188