-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
a527b28
commit 1ca8f25
Showing
8 changed files
with
873 additions
and
831 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,11 @@ | ||
## -- R CMD check results -------------------------------------- geobr 1.6.599909 ---- | ||
Duration: 3m 49.4s | ||
## ── R CMD check results ───────────────────────────────────── geobr 1.8.0 ──── | ||
Duration: 8m 3.8s | ||
|
||
> checking data for non-ASCII characters ... NOTE | ||
❯ checking data for non-ASCII characters ... NOTE | ||
Note: found 58 marked UTF-8 strings | ||
|
||
0 errors v | 0 warnings v | 1 note x | ||
0 errors ✔ | 0 warnings ✔ | 1 note ✖ | ||
|
||
* This is a submission to get the geobr package back on CRAN. | ||
|
||
The geobr package was suspended on CRAN on January 2022 because it continuously failed CRAN's policy to "fail gracefully" when there are any internet connection problems. | ||
|
||
We have scrutinized the package, which has now gone through structural changes to address this issue. Here are the main changes: | ||
1. New internal function `check_connection()` and tests that cover cases when users have no internet connection, whem url links are offline, time out or work normally. | ||
2. All functions that require internet connection now use `check_connection()` and return informative messages when url links are offline or timeout. | ||
3. The data used in the package is now simultaneously stored in two independent servers, where one of them is used as a backup link. In other words, the geobr will download the data from server 1. If, for some reason, the download fails because of internet connection problems, then geobr tries to download the data from server 2. If this second attempt fails, then the package returns `invisible(NULL)` with an informative message. | ||
|
||
We believe these changes and the redundancy in data storage have made the geobr package substantially more robust and in line with CRAN's policies. | ||
* Update to version v.1.8.0 with one new function and a few bug fixes. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.