This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Fix zip path to createArchive path before upload (Fixes #121) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unable to understand why this test is failing. It seems that the error is being thrown from the only place where the function I have tested this on my machine with an actual project using |
- Ensures that the package.json's default directory for the code is considered before suggesting the zip path Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
icyflame
force-pushed
the
fix-zip-path-before-upload
branch
from
6dad276
to
263a0b5
Compare
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-standard documentRoot is used, then
uploaddoesn't work.uploadalways tries to uploadwww.zip, althoughUtils.createArchiveis creating the archive with the same name as indocumentRootinside the project config.Fixes #121