Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix doc link in HTML representation of estimators #2131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Oct 25, 2024

Description

This PR fixes the interactive HTML representation of sklearnex estimators that don't have a scikit-learn analog to offer a clickable link to their docs, the same way scikit-learn estimators do, which is currently not working.

Before:
image

After:
image

Note: here I'm using the "latest" tag, as I wasn't sure how to get the link to the actual version of sklearnex that is used at runtime. Currently, this "latest" tag points to a 2023 release, so it won't work as-is until that issue is fixed.


PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

Performance

Not applicable

@david-cortes-intel david-cortes-intel marked this pull request as draft October 25, 2024 08:31
@david-cortes-intel david-cortes-intel marked this pull request as ready for review October 25, 2024 10:23
@david-cortes-intel david-cortes-intel marked this pull request as draft October 25, 2024 11:10
@david-cortes-intel david-cortes-intel marked this pull request as ready for review October 25, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant