-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kunit: add extra coverage #327
Conversation
317c1cd
to
6d9631a
Compare
d306ed5
to
8a6ce01
Compare
repo/linux/gmprice
Outdated
@@ -0,0 +1,5 @@ | |||
url: https://github.com/gmprice/linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be included, pls remove this commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
@@ -137,7 +137,7 @@ LIST_KUNIT_TEST: v5.5-rc1 | |||
LIVEPATCH: v4.0-rc1, x86_64 | |||
LWTUNNEL: v4.3-rc1 | |||
MEMCPY_KUNIT_TEST: v5.16-rc1 | |||
MEMCPY_SLOW_KUNIT_TEST: v6.2-rc1 | |||
MEMCPY_SLOW_KUNIT_TEST: v6.2-rc6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update change log to mention which kernel commit adds this kconfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok! i will update the change log later about this.
i have consulted oliver about this,he says it doesn't need such a fine query, just write rc1 by default .
include/kunit
Outdated
@@ -81,7 +81,7 @@ need_kconfig: | |||
|
|||
# conflict with KASAN | |||
# - KMSAN: y | |||
# - KMSAN_KUNIT_TEST: m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls skip this kconfig, as the early comment mentioned "# conflict with KASAN"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!i skip it.
include/kunit
Outdated
@@ -104,6 +104,7 @@ need_kconfig: | |||
- HAVE_ARCH_KMSAN: y | |||
- KMSAN: y | |||
- MEMCPY_SLOW_KUNIT_TEST: y | |||
- MMU: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change, any relationship to DAMON_VADDR_KUNIT_TEST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made a mistake,only have to add x86-related configuration,but this one is not.i have deleted and committed the right one.
8a6ce01
to
17047b3
Compare
include/kunit
Outdated
@@ -93,6 +93,7 @@ need_kconfig: | |||
- FAT_KUNIT_TEST: m | |||
|
|||
# below are kunit test configs of bool type | |||
- MEMCPY_SLOW_KUNIT_TEST: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's already code to disable this
# disable slow memcpy kunit test which are also part of MEMCPY_KUNIT_TEST but exhaustive
- MEMCPY_SLOW_KUNIT_TEST: n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
programs/kunit/run
Outdated
@@ -11,7 +11,7 @@ if [[ "$group" = "group-00" ]]; then | |||
test_array=("bitfield_kunit" "test_bits" "cmdline_kunit" "ext4-inode-test" "test_hash" \ | |||
"test_linear_ranges" "list-test" "memcpy_kunit" "dev_addr_lists_test" "resource_kunit" \ | |||
"lib_test" "sysctl-test" "time_test" "test_list_sort" "test_sort" "kasan_test" \ | |||
"kfence_test" "mptcp_crypto_test" "mptcp_token_test" "rational-test" "slub_kunit" \ | |||
"kmsan_test" "kfence_test" "mptcp_crypto_test" "mptcp_token_test" "rational-test" "slub_kunit" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check early comments carefully that this should not be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
17047b3
to
e697c49
Compare
@@ -172,6 +172,9 @@ need_kconfig: | |||
- USB4_DMA_TEST: m | |||
- UNICODE_NORMALIZATION_SELFTEST: m | |||
- UNICODE: m | |||
- TSNEP_SELFTESTS: y | |||
- TSNEP: m | |||
- PTP_1588_CLOCK_OPTIONAL: m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need be put after "# below are kunit test configs of bool type" line
also refer to IOMMUFD_TEST, put dependency kconfigs before it, and have empty line before/after.
- DEBUG_KERNEL: y
- FAULT_INJECTION: y
- IOMMUFD
- IOMMUFD_TEST: y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll refer to this example..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls also move its dependency together. Since it has 3 kconfigs together, pls add empty line before/after them.
@@ -175,6 +175,7 @@ need_kconfig: | |||
- TSNEP_SELFTESTS: y | |||
- TSNEP: m | |||
- PTP_1588_CLOCK_OPTIONAL: m | |||
- TEST_REF_TRACKER: m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need empty line after this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
@@ -179,6 +179,7 @@ need_kconfig: | |||
- TEST_OBJAGG: m | |||
- OBJAGG: m | |||
- TEST_LOCKUP: m | |||
- TEST_DHRY: m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need add empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!i have added an empty line.
include/kunit
Outdated
@@ -190,6 +190,10 @@ need_kconfig: | |||
- SND_TEST_COMPONENT: m | |||
- SCF_TORTURE_TEST: m | |||
- REED_SOLOMON_TEST: m | |||
- NITRO_ENCLAVES_MISC_DEV_TEST: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this one after # below are kunit test configs of bool type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
etc/kconfigs.yaml
Outdated
@@ -276,6 +276,7 @@ USB4: v5.6-rc1 | |||
USB4_KUNIT_TEST: v5.9-rc1 | |||
USER_EVENTS: v5.18-rc1 | |||
USERFAULTFD: v4.3-rc1 | |||
V4L_TEST_DRIVERS: v5.8-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks no need to have this, as it builds a test driver not something that runs test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
etc/kconfigs.yaml
Outdated
@@ -48,6 +48,7 @@ DAMON_LRU_SORT: v6.0-rc1 | |||
DAMON_PADDR: v5.16-rc1 | |||
DAMON_RECLAIM: v5.16-rc1 | |||
DMABUF_SELFTESTS: v5.4-rc1 | |||
DMAPOOL_TEST: v6.4-rcl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commit is for "include/kunit: add DRM_VC4_KUNIT_TEST", does this DMAPOOL_TEST need a separated commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,it need a separated commit,it's my mistake to put it in this commit.
etc/kconfigs.yaml
Outdated
@@ -160,6 +160,7 @@ MPTCP: v5.6-rc1 | |||
MPTCP_IPV6: v5.6-rc1 | |||
MPTCP_KUNIT_TEST: v5.13-rc1 | |||
MCTP_TEST: v5.16-rc1 | |||
MEDIA_TEST_SUPPORT: v5.8-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can be ignored, the config itself doesn't do any test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
etc/kconfigs.yaml
Outdated
@@ -68,6 +68,7 @@ DRIVER_PE_KUNIT_TEST: v5.13-rc1 | |||
DRM_DEBUG_SELFTEST: v4.18-rc1, <= v6.0 | |||
DRM_VC4_KUNIT_TEST: v6.3-rc1 | |||
DRM_KUNIT_TEST: v6.0-rc1 | |||
DVB_TEST_DRIVERS: v5.10-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can be ignored, it builds a driver but not do any test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
@@ -284,7 +284,7 @@ WW_MUTEX_SELFTEST: v4.11-rc1 | |||
X86_CPU_RESCTRL: v5.0-rc1 | |||
X86_INTEL_TSX_MODE_AUTO: v5.4-rc1 | |||
X86_INTEL_TSX_MODE_OFF: v5.4-rc1 | |||
X86_INTEL_TSX_MODE_ON:: v5.4-rc1 | |||
X86_INTEL_TSX_MODE_ON: v5.4-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the patch subject need be like etc/kconfigs.yaml: fix typo of X86_INTEL_TSX_MODE_ON::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok! i have modified it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a test to see if my comments show
81d959d
to
3a628aa
Compare
@@ -180,6 +180,8 @@ need_kconfig: | |||
|
|||
# below are kunit test configs of bool type | |||
- TSNEP_SELFTESTS: y | |||
- HAVE_STATIC_CALL: y | |||
- STATIC_CALL_SELFTEST: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help add empty lines before/after these 2 lines to view them as a group (kconfig and its dependency)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
include/kunit
Outdated
@@ -186,9 +186,13 @@ need_kconfig: | |||
- SND_TEST_COMPONENT: m | |||
- SCF_TORTURE_TEST: m | |||
- REED_SOLOMON_TEST: m | |||
- NITRO_ENCLAVES: m | |||
- PCI: y | |||
- HAVE_PCI:y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need be moved to be together with NITRO_ENCLAVES_MISC_DEV_TEST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!moved "PCI" and "HAVE_PCI" to be together with "NITRO_ENCLAVES_MISC_DEV_TES"
include/kunit
Outdated
@@ -93,6 +93,8 @@ need_kconfig: | |||
- FAT_KUNIT_TEST: m | |||
|
|||
# below are kunit test configs of bool type | |||
- DAMON_KUNIT_TEST: y | |||
- MEMCPY_SLOW_KUNIT_TEST: y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is still there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have been deleted.
etc/kconfigs.yaml
Outdated
@@ -127,6 +127,7 @@ IS_SIGNED_TYPE_KUNIT_TEST: v6.1-rc1 | |||
KALLSYMS_SELFTEST: v6.2-rc1 | |||
KASAN: v4.0-rc1, x86_64 | |||
KCSAN_SELFTEST: v5.8-rc1 | |||
KASAN_MODULE_TEST: v5.12-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help ignore this test, it has too many dependencies that may need more careful check to see any confliction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
The committed records are as follows: commit 67d637516fa91c718dd60acd9358a9fb0e19b7b5 Author: Steen Hegelund <steen.hegelund@microchip.com> Date: Thu Oct 20 15:09:04 2022 +0200 net: microchip: sparx5: Adding KUNIT test for the VCAP API Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit d5528cc16893f1f64b07936b1e88aa023128debb Author: Geert Uytterhoeven <geert+renesas@glider.be> Date: Thu Dec 8 15:31:28 2022 +0100 lib: add Dhrystone benchmark test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 1253b9b87e42ab6a3d5c2cb27af2bdd67d7e50ff Author: Paul E. McKenney <paulmck@kernel.org> Date: Thu May 27 12:01:23 2021 -0700 clocksource: Provide kernel module to test clocksource watchdog Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit f03c412915f5f69f2d17bcd20ecdd69320bcbf7b Author: Peter Zijlstra <peterz@infradead.org> Date: Tue Aug 18 15:57:46 2020 +0200 static_call: Add simple self-test for static calls Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 9fe41efaca08416657efa8731c0d47ccb6a3f3eb Author: Tom Zanussi <zanussi@kernel.org> Date: Wed Jan 29 12:59:28 2020 -0600 tracing: Add synth event generation test module Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 091810dbded96c2af81f645e386e4262553e3493 Author: Jose Abreu <Jose.Abreu@synopsys.com> Date: Fri May 24 10:20:19 2019 +0200 net: stmmac: Introduce selftests support Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit d293abc0c8fbb7b1610b9f7497323028b06cd5f8 Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Date: Tue Oct 12 13:53:38 2021 +0900 ASoC: test-component: add Test Component for Sound debug/test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit e9d338a0b1799c988b678e8ccb66a442272e6aa3 Author: Paul E. McKenney <paulmck@kernel.org> Date: Wed Jun 24 15:59:59 2020 -0700 scftorture: Add smp_call_function() torture test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 4b4f3accd80304781c648b26ce4d53df082a4087 Author: Ferdinand Blomqvist <ferdinand.blomqvist@gmail.com> Date: Thu Jun 20 17:10:33 2019 +0300 rslib: Add tests for the encoder and decoder Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit dfd402a4c4baae42398ce9180ff424d589b8bffc Author: Marco Elver <elver@google.com> Date: Thu Nov 14 19:02:54 2019 +0100 kcsan: Add Kernel Concurrency Sanitizer infrastructure Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit a6bed7a541651f5845fba325e311f78c6a4a880a Author: Logan Gunthorpe <logang@deltatee.com> Date: Thu May 23 16:30:57 2019 -0600 NTB: Introduce NTB MSI Test Client Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 64836248dda20c8e7427b493f7e06d9bf8f58850 Author: Tom Zanussi <zanussi@kernel.org> Date: Wed Jan 29 12:59:31 2020 -0600 tracing: Add kprobe event command generation test module Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit a146fed56f8a06a6f17ac11ebdc7ca3f396bcb55 Author: Marco Elver <elver@google.com> Date: Wed Jan 13 17:05:56 2021 +0100 kcsan: Make test follow KUnit style recommendations Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 5b2706a4d45987dfa9102f9529a8436392526111 Author: Eric Biggers <ebiggers@google.com> Date: Thu Jan 31 23:51:44 2019 -0800 crypto: testmgr - introduce CONFIG_CRYPTO_MANAGER_EXTRA_TESTS Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 9c84f229268fa229e250b7225611d0eb7094fea0 Author: John Hubbard <jhubbard@nvidia.com> Date: Mon Dec 14 19:05:05 2020 -0800 mm/gup_benchmark: rename to mm/gup_test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 07503b3c1e13fdeb66d4531c5dcba335eed9602a Author: Longpeng <longpeng2@huawei.com> Date: Sun Nov 7 22:09:16 2021 +0800 nitro_enclaves: Add KUnit tests setup for the misc device functionality Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 17ccae8bb5c928946f6f3af14626ec458f74e6ad Author: SeongJae Park <sjpark@amazon.de> Date: Tue Sep 7 19:57:09 2021 -0700 mm/damon: add kunit tests Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 9536b64ac0d6e3151963a11441dde7ade045fb29 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Aug 19 10:59:26 2019 +0100 dma-buf: Introduce selftesting framework Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit f759f5b53f1caf734bdffcb9519d4edd877b017f Author: Maxime Ripard <maxime@cerno.tech> Date: Thu Dec 1 16:11:48 2022 +0100 drm/vc4: tests: Introduce a mocking infrastructure Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 1e837945a8854227f3f4e4d2d7abff64ed320830 Author: Steven Rostedt (VMware) <rostedt@goodmis.org> Date: Wed Jan 29 16:30:30 2020 -0500 tracing: Move tracing selftests to bottom of menu Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 9a75a7cd03c957fd13c39f01402e952c5ad4aebc Author: Dipen Patel <dipenp@nvidia.com> Date: Fri Apr 22 13:52:20 2022 -0700 hte: Add Tegra HTE test driver Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 881c5149543a3a391ab6ce2ebe70235924f15d9c Author: Dave Hansen <dave@linux.vnet.ibm.com> Date: Mon Jul 1 13:04:44 2013 -0700 consolidate runtime testing configs Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 161eba50e183ed4ca20f6d8dec19bdc526d2b2b9 Author: Jeremy Kerr <jk@codeconstruct.com.au> Date: Sun Oct 3 11:17:04 2021 +0800 mctp: Add initial test structure and fragmentation test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 0bbcd22556ef203b29e39a6ce1bd7e9523b6032e Author: Andrew Jeffery <andrew@aj.id.au> Date: Thu Jan 14 13:44:31 2021 +1030 mmc: sdhci-of-aspeed: Add KUnit tests for phase calculations Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit f96e8577da1026c344e49c75111303888d225389 Author: Joel Fernandes (Google) <joel@joelfernandes.org> Date: Thu Jul 12 14:36:11 2018 -0700 lib: Add module for testing preemptoff/irqsoff latency tracers Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit 509e56b37cc32c9b5fc2be585c25d1e60d6a1d73 Author: Mahesh Bandewar <maheshb@google.com> Date: Mon Jul 1 14:39:01 2019 -0700 blackhole_dev: add a selftest Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows: commit def8574308edbc3bca821fb965e429a2fe5f4971 Author: Keith Busch <kbusch@kernel.org> Date: Thu Jan 26 13:51:14 2023 -0800 dmapool: add alloc/free performance test Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
The committed records are as follows,and it's committed in v6.2-rc6 instead of v6.2-rc1 commit 4acf1de35f41549e60c3c02a8defa7cb95eabdf2 Author: Kees Cook <keescook@chromium.org> Date: Fri Jan 6 19:47:05 2023 -0800 kunit: memcpy: Split slow memcpy tests into MEMCPY_SLOW_KUNIT_TEST Signed-off-by: Jiaqi Zhao <jiaqi.zhao@intel.com>
3a628aa
to
9a7416f
Compare
thanks for the patch |
No description provided.