Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-github to V65 #2359

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

grahamhar
Copy link
Contributor

@grahamhar grahamhar commented Aug 21, 2024

Resolves #2358


Before the change?

  • go-github@v63

After the change?

  • go-github@v65

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?

Example of failing test.

RUN   TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_organization_account
    data_source_github_repository_file_test.go:166: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
         <= read (data resources)
        
        Terraform will perform the following actions:
        
          # data.github_repository_file.test will be read during apply
          # (depends on a resource or a module with changes pending)
         <= data "github_repository_file" "test" {
              + commit_author  = (known after apply)
              + commit_email   = (known after apply)
              + commit_message = (known after apply)
              + commit_sha     = (known after apply)
              + content        = (known after apply)
              + file           = "test"
              + id             = (known after apply)
              + ref            = (known after apply)
              + repository     = "tf-acc-test-2ly8t"
              + sha            = (known after apply)
            }
        
          # github_repository.test will be updated in-place
          ~ resource "github_repository" "test" {
                id                          = "tf-acc-test-2ly8t"
                name                        = "tf-acc-test-2ly8t"
              - vulnerability_alerts        = true -> null
                # (32 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccGithubRepositoryFileDataSource (28.72s)
    --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided (11.38s)
        --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_individual_account (0.00s)
        --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_organization_account (11.38s)
    --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name (17.35s)
        --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_individual_account (0.00s)
        --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_organization_account (17.34s)
FAIL
FAIL    github.com/integrations/terraform-provider-github/v6/github     29.802s
FAIL

@grahamhar grahamhar changed the title chore: update go-github to V64 chore: update go-github to V65 Sep 16, 2024
go.mod Outdated
github.com/google/go-github/v63 v63.0.0
github.com/google/go-github/v64 v64.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to bump this to v65 and remove the indirect below, running go mod tidy should then also remove v64 from go.sum

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was rushing and missed this step, done now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@zepeng811
Copy link
Contributor

@kfcampbell @nickfloyd (sorry just tagging some maintainers who recently approved PRs)

can we get some eyes on this PR please. It helps unblock couple other PRs that is currently blocked requiring newer version of google/go-github

@MXfive
Copy link

MXfive commented Sep 30, 2024

@grahamhar @kfcampbell @nickfloyd

This is has been open for over a month and blocking a few other PRs now, possible to have this merged or taken over by someone with bandwidth to do so?

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR dependencies Pull requests that update a dependency file labels Oct 1, 2024
@nickfloyd
Copy link
Contributor

@grahamhar @kfcampbell @nickfloyd

This is has been open for over a month and blocking a few other PRs now, possible to have this merged or taken over by someone with bandwidth to do so?

Apologies for the delay. I'm looking at this today and should have it merged in and shipped.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?

Example of failing test.

@grahamhar unfortunately this failure has crept into our main branch and will need to be dealt with separately. Fortunately for this case, this means we can take this PR as-is now.

As always, thank you for your attention to the testing in this provider.

@kfcampbell kfcampbell merged commit 668d743 into integrations:main Oct 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINT]: Update version of go-github
5 participants