Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests pass using bundler, once yaml and multi_json are properly required #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kornypoet
Copy link
Contributor

When running tests using bundle exec rake rspec, the require statement for yaml is missing and causing tests to fail.

The require statement for this library is contained within the ConfigFile#read_yaml method; similarly the require statement for multi_json is contained in ConfigFile#read_json. Since both methods are top-level features, and are fully tested, these require statements should be moved into the main class loader. This will cause no dependency issues as yaml has been a standard ruby library since 1.8.7 and multi_json is listed as a dependency in both the Gemfile and the gemspec.

Break the silence, yo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant