Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: selective export of layouts #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Drarok
Copy link

@Drarok Drarok commented Apr 6, 2021

This will undoubtedly need me to do some tidying-up to match the current standards, but I figured it was worthwhile as a starting point to make this as a PR so we can discuss it.

Instead of exporting everything into one big file, we wanted to select individual models to export the layouts of, which is what this aims to do.

image

@ScottAgirs
Copy link
Contributor

Hey @Drarok thanks for the PR this is a great idea, I love it!

In terms of controllers/API - is there anything that comes to mind that is missing/could be added before this is merged?

Also could you please elaborate on the "current standards" parts, what did you mean by that?

Thanks again for the PR, this is an awesome idea!

@ScottAgirs ScottAgirs added Discussion Talk about improvements/changes enhancement New feature or request feature ✨ labels Apr 6, 2021
@Drarok
Copy link
Author

Drarok commented Apr 6, 2021

I had to guess a lot, such as how to fetch the available content types, but mainly I wasn't sure if I was following coding standards or anything like that. It's functional but not pretty! 🙂

@ScottAgirs
Copy link
Contributor

@Drarok ahh understood! : ) Thank you for giving this a thought and for this feedback.

I'm planning on adding some more contributor guides and description of existing codebase in near future. But definitely could use some help there, haha.

With that said, I'll give this a test later tonight and will aim to merge asap, I like the idea of this feature a lot!

@ScottAgirs
Copy link
Contributor

Hey @Drarok , sorry for the delay, I have just release 3.5.30 with updated routes and some cleanups.

Could you please tweak your PR to be up to date with that? Many thanks and I will take a look ASAP to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Talk about improvements/changes enhancement New feature or request feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants