Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark update and correction #844

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Conversation

Will-LWE
Copy link

Hello,

Here are the changes made that have been tested:

  • Bookmarks menu is visible only if a bookmark is present ;
  • The windows of VCardEditor, InvitationDialog and RoomCreationDialog are now centered to the screen ;
  • The windows of HistoryTranscript, ScratchPadPlugin (Notes and Tasks) and UserSearchService are larger and adapted to the screen ;
  • Conference Settings window is better adjusted on the screen ;
  • Unfiled Group can be disabled from default.properties ;
  • Change Nickname button can be disabled from default.properties ;
  • Conference Settings button can be disabled from default.properties ;
  • Register button on a Conference Room can be disabled from default.properties ;
  • Full JID address can be showed instead of the username when hovering with the mouse cursor over a user in the contact list, from default.properties ;
  • Prohibit modification of user profile but only allow the avatar change that can be very useful in case of use of LDAP / Active Directory from default.properties ;
  • Profile Lookup can be disabled from default.properties ;

Review of French translation of Spark and Transfer Guard Plugin to be a little more professional in case of use in enterprise. French translation added or updated regarding:

  • Spark ;
  • Plugin : Battleships ;
  • Plugin : fastpath ;
  • Plugin : jingle ;
  • Plugin : meet ;
  • Plugin : otr ;
  • Plugin : roar ;
  • Plugin : sip ;
  • Plugin : speeling ;
  • Plugin : tictactoe ;
  • Plugin : transferguard ;

A correction was made: If the option DISABLE_EXIT is set to true, all windows size and position are not stored in the file “layout.settings” because Spark application is killed when a user logout or reboot the computer. All windows size and position are now saved in real time when a user made a change.

All new options available from default.properties have been planned and can be used in the future from the client management on OpenFire (plugin Manager/Enterprise) but disabled by default because must be implemented on the future version of OpenFire server. For the moment, the new options works only from default.properties file.

I hope that these corrections and adaptations made will be present in the new release of Spark.

Bests regards.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

@Will-LWE Will-LWE Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The window of VCardEditor is now centered to the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This other code relate to : Prohibit modification of user profile but only allow the avatar change that can be very useful in case of use of LDAP / Active Directory from default.properties .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Real time save settings of window size and position.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The window of InvitationDialog is now centered to the screen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The window RoomCreationDialog is now centered to the screen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Change Nickname button can be disabled from default.properties.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Conference Settings button can be disabled from default.properties.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Conference Settings window is better adjusted on the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The window of HistoryTranscrip (chat history) is larger and adapted to the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The windows of ScratchPadPlugin (Notes and Tasks) are larger and adapted to the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : The window of UserSearchService (Search Window) is larger and adapted to the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Full JID address can be showed instead of the username when hovering with the mouse cursor over a user in the contact list, from default.properties.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code relate to : Profile Lookup can be disabled from default.properties.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin Battleships.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin fastpath.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin jingle.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin meet (Pade Meeting).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation update of plugin OTR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation update of plugin ROAR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin SIP.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation update of plugin speeling.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation of plugin tictactoe.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation update of plugin transferguard.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation update of Spark.

@Will-LWE
Copy link
Author

I have commented out all the changed files, it should be easy to find the changes. The modifications are quite simple.

@stokito
Copy link
Contributor

stokito commented Aug 4, 2024

It would be difficult to review the PR because it has many changes.
First of all translations a better to be made on the Transifex. I hope the Spark developers will be able to merge you translations but then please use the Transifex.

You used manual upload of files. Generally speaking you should try to learn how to use the git version control system. With the git you can change many files then "commit" the change to a history (git log). For the commit you must specify a description what was changed for why.
Then you can see step by step build a change list of commits that would be easier to understand.
You better to use IDE for this, I highly recommend you the free IntelliJ Community Edition.
Check a tutorial, it's not than complicated and once you learn it you become more powerful developer
https://www.google.com/search?q=intellij+community+git+tutorial&tbm=vid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants