OF-2892 Available Plugins page: redesign to make Documentation easier to see #2541
+44
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokito
force-pushed
the
OF-1823_plugins
branch
from
ddd1591
to
3b217ed
Compare
…ame instead of plugin.available.open_source And remove the unused open_source key
stokito
force-pushed
the
OF-1823_plugins
branch
from
3b217ed
to
5917a86
Compare
stokito
changed the title
Fishbowler
reviewed
Nov 1, 2024
Comment on lines
-144
to
-152
| String releaseDate = null; | ||
| final String releaseDateString = plugin.attributeValue("releaseDate"); | ||
| if( releaseDateString!= null) { | ||
| try { | ||
| releaseDate = RELEASE_DATE_DISPLAY_FORMAT.format(RELEASE_DATE_FORMAT.parse(releaseDateString)); | ||
| } catch (final ParseException e) { | ||
| Log.warn("Unexpected exception parsing release date: " + releaseDateString, e); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this exists because there are some older plugins out there with non-ISO release dates
There was a problem hiding this comment.
yes, I forgot to comment on this. We don't try to parse the date and just show it in UI. So its format doesn't affect anything.
There was a problem hiding this comment.
I anyway will recheck plugins. I remember that for the Pade plugin I already sent a PR
|
I've not tested this (yet) but this looks to be an awesome change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Plugins and Available plugins pages have two icons for documentation (README) and changelog.
The icons are very small and placed together that makes it difficult to understand them.
The icons are only 16px and the only way to understand is to put a cursor over them to see a title. This wouldn't be possible to to from a mobile at all (minor issue).
As a solution we can switch to a table where each cell can have a few lines.
I moved the changelog icon into the Version column as a an additional row. The re
Similarly the Documentation link moved into the Description column, and the Description merged into the Plugin Name.