OF-1838 XEP-0157: Improve support #1468
Conversation
|
Do we need a servlet for this? It's not a bad approach, but we hardly use servlets, and do everything in JSP. If there's a reason for having a servlet, I'm not against it. |
|
I've used servlets in a couple of places (e.g. the new System properties page). Possibly my bad for not highlighting that at the time, but ... I'd encourage use of servlets. It does make things far neater, IMHO. A much cleaner seperation of logic and display, less likely to get CSRF problems, etc. etc. |
|
I use both in plugins and would like to keep both options open. Slightly different tools to achieve the same purpose. |
|
I agree that using servlets is generally a good idea. In this instance, I'd like to keep the code somewhat consistent. I'd be happy to introduce Servlets, but then I'd ask you to introduce them everywhere. :) |
|
I'd like to see servlets everywhere, but practically speaking I think the only way you're going to get it done is a few at a time. |
|
Three years in, we're still halfway through JSTL :( |
|
@mnsuccess why prefix every column name with the letter 'c'? |
|
|
Ah I see. It's a bit redundant as there will only be contacts in that table anyway, but hey :) |
|
Should I keep using servlet ? |
|
Using servlets is fine, but please stop using the letter |
|
@mnsuccess Are you still working on this PR? |
|
@akrherz yes I'm still working on this !! |
|
Hi @mnsuccess, are you able to rebase this PR onto current master? |
|
@mnsuccess: Have you progressed? |
XEP-0157 support in Openfire should be improved upon. Ideally, the admin console is used to determine what users are exposed as what kind of XEP-0157 contact.