Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add multi node (validator) testnet #4377

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

feat: Add multi node (validator) testnet #4377

wants to merge 40 commits into from

Conversation

likesToEatFish
Copy link
Contributor

@likesToEatFish likesToEatFish commented Sep 29, 2024 •
edited
Loading

Closes: #4374

This PR added the feature to ignite multi-node testnet.

Test steps:

  1. ignite scaffold chain github.com/test/mychain
  2. cd mychain
  3. go install ./...
  4. ignite testnet multi-node

The interface looks like this:

image

@likesToEatFish
Copy link
Contributor Author

likesToEatFish commented Sep 29, 2024 •
edited
Loading

The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow.

@likesToEatFish likesToEatFish changed the title INIT: Multi Node (Validator) Testnet INIT: Add multi node (validator) testnet Sep 29, 2024
@julienrbrt julienrbrt changed the title INIT: Add multi node (validator) testnet feat: Add multi node (validator) testnet Sep 29, 2024
julienrbrt
julienrbrt reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up so fast! This is a good start 🙏🏾

ignite/cmd/model/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/cmd/model/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/cmd/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/config/chain/base/config.go Outdated Show resolved Hide resolved
ignite/services/chain/runtime.go Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Outdated Show resolved Hide resolved
ignite/config/chain/base/config.go Outdated Show resolved Hide resolved
ignite/cmd/testnet_multi_node.go Show resolved Hide resolved
@likesToEatFish
Copy link
Contributor Author

likesToEatFish commented Oct 14, 2024 •
edited
Loading

do you mean it looks like this:
image

@Pantani
Copy link
Collaborator

Pantani commented Oct 14, 2024 •
edited
Loading

@likesToEatFish any thought about it? Why did you marked as solved?

#4377 (comment)

@likesToEatFish
Copy link
Contributor Author

@likesToEatFishBạn có suy nghĩ gì về vấn đề này không? Tại sao bạn đánh dấu là đã giải quyết?

#4377 (bình luận)

Sorry, I replied but for some reason it is pending

image

likesToEatFish and others added 4 commits October 14, 2024 22:12
@likesToEatFish @Pantani
Update ignite/cmd/bubblemodel/testnet_multi_node.go
b25b9d4 
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@likesToEatFish @Pantani
Update ignite/cmd/bubblemodel/testnet_multi_node.go
697e05c 
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@likesToEatFish
remove ctx
28d9df7
@likesToEatFish
add comment
6a9a4f4
@likesToEatFish
Copy link
Contributor Author

I apologize for the many comments I've provided that are still pending. I didn't notice their status, which serves as a lesson for me to stay more attentive in the future.

Pantani
Pantani reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we guarantee the node is started correctly, or if it will throw an error in the execution?

ignite/cmd/bubblemodel/testnet_multi_node.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Oct 18, 2024
Pantani
Pantani previously approved these changes Oct 18, 2024
View reviewed changes
julienrbrt
julienrbrt reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! In the meantime we've upgraded to v0.52, the wiring needs to change slightly. Could you update it? (no crisis, bank module has a different package name f.e)

Then we can merge 🙏🏾 Thank you so much for contributing again.

Pantani
Pantani reviewed Oct 20, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@likesToEatFish @Pantani
Update changelog.md
e9e8dd2 
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@likesToEatFish
Copy link
Contributor Author

likesToEatFish commented Oct 20, 2024 •
edited
Loading

Thanks @julienrbrt @Pantani , I learned a lot of new things from this PR! 🙏🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@likesToEatFish likesToEatFish

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INIT: Multi Node (Validator) Testnet
3 participants
@likesToEatFish @julienrbrt @Pantani