-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add multi node (validator) testnet #4377
base: main
Are you sure you want to change the base?
Conversation
The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking this up so fast! This is a good start 🙏🏾
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Show resolved
Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Outdated
Show resolved
Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Outdated
Show resolved
Hide resolved
@likesToEatFish any thought about it? Why did you marked as solved? |
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
I apologize for the many comments I've provided that are still pending. I didn't notice their status, which serves as a lesson for me to stay more attentive in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we guarantee the node is started correctly, or if it will throw an error in the execution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! In the meantime we've upgraded to v0.52, the wiring needs to change slightly. Could you update it? (no crisis, bank module has a different package name f.e)
Then we can merge 🙏🏾 Thank you so much for contributing again.
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Thanks @julienrbrt @Pantani , I learned a lot of new things from this PR! 🙏🏾 |
Closes: #4374
This PR added the feature to ignite multi-node testnet.
Test steps:
ignite scaffold chain github.com/test/mychain
cd mychain
go install ./...
ignite testnet multi-node
The interface looks like this: