Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the functionality of onChange listener in general setting #1166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dakshmehta007
Copy link

Description

Update the functionality of onChange Click listener in General setting.

Related Issues

Fixes #807

Screenshots (if applicable)

Screenshot 2024-09-11 170001

##Detail Description: -

This pull request addresses an issue where the navigation in the settings page only works when clicking on the text, not the entire tab area. The changes ensure that the navigation is triggered only when the text is clicked, preventing clicks on the surrounding div from affecting the navigation.

##Changes Made:

1.Wrapped the text in each tab label with a span element.
2.Added onClick event handlers to the span elements to stop event propagation.

##Files Modified:
Settings.js

##Steps to Reproduce the Issue:
1.Navigate to the settings page.
2.Try clicking on the tab area outside the text.
3.Observe that the navigation does not work unless the text is clicked.

##Steps to Verify the Fix:

1.Navigate to the settings page.
2.Click directly on the text in the tab.
3.Verify that the navigation works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings navigation work only when click in text not tab
1 participant