[ cleanup ] Make Nat
's NonZero
to be an alias for IsSucc
#3405
+30
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Historically for some strange reason in
Data.Nat
we have two equivalent definitions:IsSucc
andNonZero
. Other standard types have standard pattern ofIs<Constructor>
type,ItIs<Constructor>
constructor of proof andisIt<Constructor>
forDec Is<Consturctor>
.IsSucc
follows this pattern, whenNonZero
does not. However,NonZero
is a handy name for this.But the fact that there are two different types for this and the fact that some standard and non-standard functions use one of them, and others use the other, triggers a lot of people (I personally know around five of them).
What I suggest is to make
NonZero
to be an alias forIsSucc
and to declare a deprecated alias for original constructor ofNonZero
to be backward compatible at least on usages at RHS.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md
(and potentially alsoCONTRIBUTORS.md
).