Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ver 1jb to TMAP8's V&V suite #185

Open
wants to merge 14 commits into
base: devel
Choose a base branch
from
Open

Add Ver 1jb to TMAP8's V&V suite #185

wants to merge 14 commits into from

Commits on Oct 15, 2024

  1. Update ver-1jb

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac777db View commit details
    Browse the repository at this point in the history

  2. Clean up and devel of input files: 

    - decay term for trapped tritium
- use unit system
- update comments
    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b0a3351 View commit details
    Browse the repository at this point in the history

  3. Complete input file for ver-1jb

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    43ad9a0 View commit details
    Browse the repository at this point in the history

  4. Add python script for ver-1jb

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b11b671 View commit details
    Browse the repository at this point in the history

  5. Add tests and gold files

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    395b292 View commit details
    Browse the repository at this point in the history

  6. Update documentation

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3a6bb0b View commit details
    Browse the repository at this point in the history

  7. - Correct input file (one of the signs were wrong) 

    - add case with equivalent concentrations of mobile and trapped tritium
    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ecea800 View commit details
    Browse the repository at this point in the history

  8. Update ver-1jb documentation and clean up

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    14a8b9b View commit details
    Browse the repository at this point in the history

  9. ver-1d and ver-1ja clean up prompted by ver-1jb case development 

    (Close. #145)
(Ref. #12)
    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a71df96 View commit details
    Browse the repository at this point in the history

  10. Fix documentation and refine solving adn convergence options to accel… 

    …erate test, increase accuracy, and fix recover failure
    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d660948 View commit details
    Browse the repository at this point in the history

  11. Refine convergence and clean up

    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b5c8516 View commit details
    Browse the repository at this point in the history

  12. Update file_base output names to avoid outputs being overridden. 

    This should solve the recover issue
    @simopier
    simopier committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1c1c6ff View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Chaitanya Bhave <65254651+chaibhave@users.noreply.github.com>
    @simopier @chaibhave
    simopier and chaibhave authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a30ef32 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @simopier
    simopier committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0874728 View commit details
    Browse the repository at this point in the history