[Review] Changes by danxoo #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoninas
force-pushed
the
feature/danxxo/review-code
branch
from
a8f3537
to
9fa23e4
Compare
timoninas
force-pushed
the
feature/danxxo/review-code
branch
from
9fa23e4
to
cd20c0f
Compare
timoninas
commented
Dec 6, 2023
| @@ -11,6 +11,8 @@ final class AutorizeViewController : UIViewController{ | |||
|
|
|||
There was a problem hiding this comment.
Нет разделения логики на слои
| // Call the delegate method | ||
| delegate?.saveButtonTapped(username: username, password: password) | ||
| // Закрываем представление настроек | ||
| dismiss(animated: true, completion: nil) | ||
| } | ||
| // |
There was a problem hiding this comment.
давай протокол снизу вынесем в отдельный файл
| @@ -69,7 +71,7 @@ final class AutorizeViewController : UIViewController{ | |||
|
|
|||
| ask_password_Field.text = "Введите пароль:" | |||
| view.addSubview(ask_password_Field) | |||
|
|
|||
| ask_password_Field.translatesAutoresizingMaskIntoConstraints = false | |||
There was a problem hiding this comment.
Давай будем называть свойства по camelCase, как в Swift принято
ask_password_Field -> askPasswordField
| @@ -187,7 +189,7 @@ final class AutorizeViewController : UIViewController{ | |||
| let password = passwordTextField.text ?? "" | |||
| let password2 = password2TextField.text ?? "" | |||
| // Получаем значение поля ввода пароля или оставляем пустую строку, если поле пустое | |||
| // Добавлено условие для проверки, что оба поля имени пользователя и пароля не пусты | |||
| // Добавлено условие для проверки, что оба поля имени пользователя и пароля не пусты | |||
| guard !username.isEmpty && !password.isEmpty && !password2.isEmpty && (password == password2) else { | |||
| if (username.isEmpty) { | |||
| Error_label.text = "Ошибка! Пустое имя пользователя(" } | |||
There was a problem hiding this comment.
Давай мб тут алерт нативный эпловый (UIAlertController) будем показывать, о том что что-то не так
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.