Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variables section. #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Caellian
Copy link

@Caellian Caellian commented Nov 4, 2023

Add Java AWT to toolkits.
Add application specific variables section for accumulating all the PLZ_WAYLAND env flags.

Add Java AWT to toolkits.
Add application specific variables section for accumulating all the PLZ_WAYLAND env flags.
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonreparenting and moz are automatically set by hl. Worth noting...

@Caellian
Copy link
Author

Caellian commented Nov 4, 2023

nonreparenting and moz are automatically set by hl

I moved them to a separate section so users know they don't require setting. Let me know whether that's fine, should be removed altogether, or just a comment next to the items would've been better.

If the separate section is kept, I guess I'll go through sources to add any other variables that are configured - just the ones that interact with other programs (i.e. not set by all WMs)

@fufexan
Copy link
Member

fufexan commented Jan 31, 2024

You may want to also add SDL_VIDEODRIVER=wayland, QT_QPA_PLATFORM=wayland and XDG_SESSION_TYPE=wayland.

@vaxerski
Copy link
Member

already set also includes XDG_SESSION_TYPE and XDG_CURRENT_DESKTOP for sure.

@fufexan
Copy link
Member

fufexan commented Jan 31, 2024

I didn't see them when grepping through the source, my bad.

@Caellian
Copy link
Author

Caellian commented Feb 6, 2024

Not sure whether you want "already set" section to be included @vaxerski. If I add it, you'll have to keep it up to date so lmk. IDK whether env vars are something you add/change often so I don't want to unnecessarily pile onto to the maintenance burden.

@vaxerski
Copy link
Member

vaxerski commented Feb 6, 2024

they arent changed often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants