Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quick Start #129271

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add Quick Start #129271

wants to merge 1 commit into from

Conversation

adamoutler
Copy link
Contributor

When debugging code-only changes, waiting for translations is very slow. This adds a quicker option to just execute the code without awaiting translation compilation.

Breaking change

no

Proposed change

Add a quick start option to the run & debug dropdown
image

Type of change

Limited to IDE-only.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

When dealing with code-only changes, waiting for translations is very slow.  This adds a quicker option to just execute the code without awaiting translation compilation.
@adamoutler adamoutler requested a review from a team as a code owner October 27, 2024 16:04
@home-assistant home-assistant bot added cla-signed Hacktoberfest small-pr PRs with less than 30 lines. labels Oct 27, 2024
@frenck
Copy link
Member

frenck commented Oct 27, 2024

waiting for translations is very slow.

IT is less than a second?

I feel like this is really not needed to be honest.

../Frenck

@adamoutler
Copy link
Contributor Author

adamoutler commented Oct 27, 2024

waiting for translations is very slow.

Is is less than a second?

I feel like this is really needed to be honest.

../Frenck

Takes about 1 minute when operating in default state on a machine with 20 cores. By default it parses all translations in all components.

@frenck
Copy link
Member

frenck commented Oct 27, 2024

Sounds like something is wrong on your end in this case. Running the translations for all integrations takes just a couple of hundred milliseconds on several systems (including codespaces, my laptop, and dev machine).

../Frenck

@adamoutler
Copy link
Contributor Author

I don't know what to say. It just takes a long time to run the translations script. CPU is not burdened.
translations_slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Hacktoberfest small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants