fix (mvTreeNode/mvCollapsingHeader): Keep the open state when parent … #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…window is hidden #1873
name: Pull Request
about: Create a pull request to help us improve
title: fix (mvTreeNode/mvCollapsingHeader): Keep the open state when parent window is hidden #1873
assignees: @hoffstadt
Closes #1873
Description:
This is an attempt to make the fix better than #2250.
The problem is caused by TreeNode functions returning
falsewhen the window is not visible, and we surely don't want thatfalseto interfere with the widget'svalue. That's why we only store theTreeNodeExreturn value when it really comes from user interaction (toggledOpenis true). If the window is hidden,toggledOpencan never turn into true, so it's a safe approach. Also, this way we don't have to explicitly checkwindow->SkipItems, which is an internal API in Dear ImGui (I try to cut down on the use of internal-looking APIs :) ).Concerning Areas:
None.