Support reading of Godot4 .pck files #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like this implements just reading? Which is fine, but I just want to confirm. I'll need to put a note in the readme / prevent trying to write out a .pck file with version 2 so that no one reports that as a bug. |
The PCK version 2 format is implemented for reading but not for writing.
|
That's correct. I've pushed another commit now to at least block the saving of version 2 .pck files (until someone implements that part). |
|
The way the blocking is done seems fine to me. |
|
Sure. Here's a .pck from godot-demo-projects/2d/platformer exported with Godot 4.1.1.stable.official.bd6af8e0e on Linux. |
hhyyrylainen
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements reading of Godot 4 .pck files (i.e. PCK version 2).
Decryption is not implemented. An error is produced if the pack's flags indicate that the content is encrypted.
Closes: #17