feat(swarm): removed workaround support for mock staging/unstaging

[lukasmetzner]

With the merge of moby/swarmkit#3116 the mock staging/unstaging is not needed anymore. It was introduced in our csi-driver in this commit: 619fa5c. Which is part of a large PR (squashed commit) that included experimental support for Docker swarm.

See:

• add Docker Swarm support #376
• Docker Swarm support: Remove mock staging/unstaging once possible #382

[codecov]

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.67%. Comparing base (a132c79) to head (3bb844f).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/driver/node.go	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   34.54%   34.67%   +0.13%     
==========================================
  Files          19       19              
  Lines        1621     1612       -9     
==========================================
- Hits          560      559       -1     
+ Misses       1027     1020       -7     
+ Partials       34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jooola]

Is this change backward compatible for previous docker versions?

Do we state somewhere that the docker swarm support is experimental? I could only find a statement that we do not provide official support for it.

[jooola]

Changed the scope to feat as we have some user facing changes.

[apricote]

Could you also remove the environment variable from the docker-swarm config.json?

csi-driver/deploy/docker-swarm/pkg/config.json

Lines 30 to 35 in f908f5d

	{
	"name": "FORCE_STAGING_SUPPORT",
	"description": "workaround: force staging support to make Docker 23.0.0 work without https://github.com/moby/swarmkit/pull/3116",
	"settable": ["value"],
	"value": "true"
	}

[apricote]

Is this change backward compatible for previous docker versions?

This is only compatible with docker-swarm versions that have the fix from moby/swarmkit#3116. Not sure which versions of docker-swarm include that.

Do we state somewhere that the docker swarm support is experimental? I could only find a statement that we do not provide official support for it.

In the docker swarm docs it is mentioned that the support is in beta, though I would say that "beta" is not defined for us. We do not test it and do not publish a version compatibility for docker swarm.

[apricote]

Nice cleanup :)