-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodemo #26
base: master
Are you sure you want to change the base?
Autodemo #26
Conversation
about the choice of name: rs_autoDemoName, it'll be easier for people to find this command (and understand it) if we incorporated the full original command. so either rs_autoRaceDemo with rs_autoRaceDemoName or; rs_autoDemo with rs_autoDemoName. the latter is preferable imo, though, if changing the original command name will cause trouble somehow (like if servers needs to be updated for command to be updated etc) i suppose the first one will do. also, "hour" is not really needed in demo name options, is it? can't we just keep it stacking minutes until it hits 100 and thus resets the counter anyway? and what is this "random" token? this is a huge issue for tech maps and such.. trish and myself also get a good time the first time around pretty often, and a few oldtimers that statswhore tend to kill themselves right before finish to prevent bad skill, they could also suffer badly from first demo being broken. bring back spec @ connect even if it doens't fix issue plz. didn't turn out to be a very beneficial feature anyway. |
I like As for the tokens, I don't see any harm in including hour or random, you don't have to use them. We could let minutes be the max time denomination, lets ask what people prefer. The random token was intended to avoid naming conflicts if you make an exactly tied record, again you don't have to use it. I was wondering if we should make the current date/time available as a token as well. Settled then, I'll look into spec@connect and see if it helps. |
Can confirm that starting players as spectators fixes the first demo not recording problem. |
Looks like there are still bugs on windows side, I'll outline the current behavior (before the commits from this PR) here. Join a server with empty demos folder
This issue is fixed on linux with d155941 Finish a map for the first time (assuming the demo started recording and is non-zero)
Seems like Subsequent records work as expected! |
Working on #23
First this fixes the 0kb demo issue by checking if a file exists before renaming. This issue happens when
dstart
is called butrecord
fails. The nextdstop
renames nothing to a demo.Second, I introduce
rs_autoDemoName
, I haven't fixed the default name because we should discuss that first. Available tokens are playername, mapname, hour, min, sec, milli, randomThis does not fix the issue with recording the very first run. When you join a server,
dstart
is called before you are actually ingame andrecord
fails. Hardly a big issue since noone (except weqo?) ever recs their first attempt. We could look at delaying the first dstart call or putting players in spec when they join.