Casl 534 java proxy fix #347
Conversation
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Amaneusz
force-pushed
the
CASL-534_java_as_proxy
branch
from
0fc834a
to
cbac9ee
Compare
| val constructor: KFunction<T> = primaryNonArgConstructorOf(klass) | ||
| ?: firstNonArgConstructorOf(klass) | ||
| ?: throw IllegalArgumentException("Unable to find primary or non-arg constructor for class: ${klass.qualifiedName}") | ||
| proxy = constructor.call() |
There was a problem hiding this comment.
I think, any constructor that does not require arguments is fine for us, we should always first try the primary constructor, but if that does not match, try to find any other constructor.
These checks and searching for the correct constructor can be time consuming, I would suggest to add a cache here, a concurrent hash-map, to cache the found constructors. Like:
var constructor = cache[klass]
if (constructor == null) {
constructor = ... find the correct one
cache[klass] = constructor
}We do not need any synchronization here, because we can assume that the finding operation is idempotent, so even when multiple threads in parallel enter the search and override each other, the cache should work after that as intended.
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
| @@ -512,11 +512,21 @@ actual class Platform { | |||
| if (klass.isInstance(proxy)) return proxy as T | |||
| if (doNotOverride) throw IllegalStateException("The symbol $symbol is already bound to incompatible type") | |||
| } | |||
| proxy = klass.primaryConstructor!!.call() | |||
|
|
|||
| proxy = nonArgConstructorFor(klass).call() | |||
There was a problem hiding this comment.
Please add the caching, should be just a few code lines, but avoids to always go through reflection and search through constructor lists.
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
No description provided.