Readme updates #14
Closed
Readme updates #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skylarcalvert thank you - 2 things:
|
|
@skylarcalvert looks good, can you please follow instrcutions here to sign DCO? https://github.com/helm/acceptance-testing/pull/14/checks?check_run_id=194450876 |
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Signed-off-by: Skylar Calvert <skydrewcal@gmail.com>
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Signed-off-by: Skylar Calvert <skydrewcal@gmail.com>
fixes helm#11 Signed-off-by: Skylar Calvert <skydrewcal@gmail.com>
Signed-off-by: Skylar Calvert <skydrewcal@gmail.com>
skylarcalvert
force-pushed
the
readme-updates
branch
from
41be571
to
648e3ba
Compare
|
@skylarcalvert looks like some of the changes were reverted, but DCO looks good |
|
closing due to inactivity, please re-open if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5 by adding OS specific commands to 'Viewing the results' section