Update wgpu to 0.19 and winit to 0.29 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the examples needed adjustments.
It looks like this code has been written quite a while ago, presumably when the capabilities of naga regarding WGSL were quite limited yet. I changed some stuff to what I would perceive as more idiomatic. I removed a bunch of type annotations, used built-in type aliases, and even used abstract types new with wgpu 0.19.
|
Are there any plans to merge this any time soon? |
hecrj
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wgpu update is useful for users of this crate, while the winit update is only relevant to the examples in this repo. I also touched up the WGSL code. If you prefer, I can remove the last commit.
This can be be reviewed commit by commit.
Changelogs: wgpu, winit
Thanks for this crate btw. I know the README now says this has been superseeded by glyphon, but I still think there is a place for
wgpu_glyph. At least for now. Switching to glyphon isn't straight forward if you are already usingwgpu_glyphand cosmic-text still lacks some features like changing font size within one text block. So thanks for still maintaining this!