Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TTL field #2318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added TTL field #2318

wants to merge 1 commit into from

Conversation

Gaardsholt
Copy link
Contributor

Description

Added ttl to vault_gcp_secret_impersonated_account resource

Fixes: #1812

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests were run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@Gaardsholt
added TTL field
ea25d8a 
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
@Gaardsholt Gaardsholt marked this pull request as ready for review September 5, 2024 10:18
@Gaardsholt
Copy link
Contributor Author

Can I do anything to get someone to look at this one? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault_gcp_secret_impersonated_account resource does not support ttl parameter
1 participant
@Gaardsholt