Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh): add support for key_type parameter #2218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

radek-sprta
Copy link

@radek-sprta radek-sprta commented Apr 2, 2024

Description

Add support for key_type parameter in SSH Secret Engine, so we can specify types other than the default ssh-rsa.

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests were run against all supported Vault Versions

Output from acceptance testing:

=== RUN   TestAccSSHSecretBackendCA_basic                                                              
--- PASS: TestAccSSHSecretBackendCA_basic (2.28s)                                                      
=== RUN   TestAccSSHSecretBackendCA_provided                                                                                                                                                                   
--- PASS: TestAccSSHSecretBackendCA_provided (1.68s)                                                                                                                                                           
=== RUN   TestAccSSHSecretBackend_import                                                               
--- PASS: TestAccSSHSecretBackend_import (2.66s)          
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Add support for `key_type` parameter in SSH Secret Engine, so we can
specify types other than the default `ssh-rsa`.
@radek-sprta radek-sprta marked this pull request as ready for review April 5, 2024 13:29
@murthysrd
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants