Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github commit status integration #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Github commit status integration #30

wants to merge 1 commit into from

Conversation

daurnimator
Copy link
Member

github apps need an extra dance. argoproj-labs/argocd-notifications#99

@daurnimator daurnimator force-pushed the master branch 2 times, most recently from eb61446 to 8a48194 Compare June 23, 2020 14:02
@RyanSquared RyanSquared force-pushed the master branch 3 times, most recently from 0f39268 to 4e97da9 Compare June 29, 2020 13:47
@KellerFuchs
Copy link
Member

@daurnimator I'd like to work on this, could you rebase and re-encrypt argocd/argocd-notifications/secret.enc.yaml ?

@KellerFuchs
Copy link
Member

or @RyanSquared I guess? ;3

@KellerFuchs
Copy link
Member

@daurnimator Thanks! Looks like you even updated it to use the upstream support instead of a custom 'cron' job and ruby script. <3

If I follow correctly, argocd-notifications-cm.patch.yml is applied to applicationset-generator.yml, and so the settings under template will apply to all applications deployed on argocd?

TBH this seems good to me. What's holding it as a work-in-progress?
We may want to have argo run dry-runs on our PR branches, but I can try and make a follow-up PR later.

@daurnimator
Copy link
Member Author

TBH this seems good to me. What's holding it as a work-in-progress?

Completely untested. Though it might work as-is.

@KellerFuchs
Copy link
Member

TBH this seems good to me. What's holding it as a work-in-progress?

Completely untested. Though it might work as-is.

OK. Do we (currently) have a way to test it other than deploying it?

If not, I'd be fine with deploying as-is (and being sad we are testing in production)

@daurnimator
Copy link
Member Author

OK. Do we (currently) have a way to test it other than deploying it?

not really; other than spinning up a local cluster and trying there.... but that then needs it's whole own overlay with it's own github app etc. Too much to bother with IMO.

If not, I'd be fine with deploying as-is (and being sad we are testing in production)

Sure. I'll take the PR out of draft

@daurnimator daurnimator marked this pull request as ready for review May 30, 2023 11:36
@daurnimator daurnimator changed the title WIP: github commit status integration Github commit status integration May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daurnimator @KellerFuchs