Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretraining LLaVA with SigLIP #1603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pretraining LLaVA with SigLIP #1603

wants to merge 2 commits into from

Conversation

nahidalam
Copy link

Added option for LLaVA pretraining with SigLIP

cc: pilot-j

@nahidalam
Copy link
Author

@haotian-liu any thoughts on this?

@zkyredstart
Copy link

Hi @nahidalam, your codes raise error: AttributeError: 'SiglipImageProcessor' object has no attribute 'crop_size' at the visual instruction tuning stage. Maybe training code should be changed.

@nahidalam
Copy link
Author

@zkyredstart the issue should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahidalam @zkyredstart