Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simplifyByDecoration checkbox #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

XUJINKAI
Copy link

add "Simplify" button next to "show remote branches"

this button add "--simplify-by-decoration" arg to git log, this will show topology of git branches and tags.

btw, I rename "Show Remote Branches" to "Remotes" to prevent header too long

@XUJINKAI XUJINKAI requested a review from hansu as a code owner June 26, 2023 16:24
@hansu
Copy link
Owner

hansu commented Jun 28, 2023

Can you post an example how the difference looks?

@XUJINKAI
Copy link
Author

Use git as an example:
image

After checked "Simplify" button, only branches and tags shows.
This is a very useful feature for large repos.
image

If unchecked "Show Tags", only branches shows.
image

phil294 added a commit to phil294/GitLG that referenced this pull request Jun 30, 2023
@phil294
Copy link

phil294 commented Jun 30, 2023

very useful flag for gigantic repositories!

@hansu
Copy link
Owner

hansu commented Jun 30, 2023

Ok looks like a good option to keep the overview. But can you add a setting to disable the button because the space in this bar is quite rare especially when viewing Git-Graph in a split view?

@XUJINKAI
Copy link
Author

XUJINKAI commented Jul 1, 2023

@hansu I'd like to contribute, but I am not professional in vscode extension development or typescript🤦‍♂️. sorry

Copy link

@LaksVister LaksVister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget about the unit tests

Copy link
Owner

@hansu hansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still the setting missing to show this checkbox on the bar or not.
Please add this due to space reasons as mentioned earlier.

@@ -1077,6 +1077,11 @@
"default": true,
"description": "Show Remote Branches in Git Graph by default. This can be overridden per repository from the Git Graph View's Control Bar."
},
"git-graph.repository.simplifyByDecoration": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting has now effect when I tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants