-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to skip printing skipped tests + fix FsCheck3 replay #511
base: main
Are you sure you want to change the base?
Conversation
(cherry picked from commit 3fde247)
Using the original seed has the same problem
I probably won't be able to review this for a few weeks. |
Alright. I'm back and starting to give this a look. I think these are distinct work items that should be considered separately. Trying to review them together muddies the picture of what's going on with either |
I see motivations for skipping skip messages in #453. |
Yeah my bad should have made two PRs. I updated the description with links to the diffs for the two changes
In FsCheck3 they seem to have added (or maybe factored out) a size parameter for replay in addition to the seed. Without the size, replay was playing all test inputs leading up to the failure; this change allows skipping directly to the failing test input |
That makes sense. Skipping right to the broken case would be good for debugging. I noticed that you also changed from printing the original seed to the final seed. |
Ah didn't think about that. I added it to the output |
Resolves #453 : 79f6e21
Also fixes the replay config so fscheck 3 will skip directly to the failing case: https://github.com/haf/expecto/pull/511/files/79f6e21881ae566036a22bbf0f1879454bf5784a..701746a1b3a2773ab9a011b221ce15e2f9345d0e