[GH-16351] Do not call System.exit from water.tools [nocheck] #16366
Conversation
|
Your fix has stopped h2o-3 cluster from crashing. I ran the following: curl http://localhost:54321/99/Rapids --data-urlencode 'ast=(run_tool "MojoConvertTool" ["", "", "", ""])' and got the following result:
From talking to @mmalohlava , he does not want to see the whole stack, just the error message which in this case is "Caused by:java.lang.IllegalArgumentException: Specified MOJO file (/Users/wendycwong/h2o-3) doesn't exist!", I took a look and think this is the file that passes everything over: RapidsHandler.java around line 38 where the whole stack errors are passed as well.
|
| mainInternal(args); | ||
| } | ||
| catch (IllegalArgumentException e) { | ||
| System.err.println(e.getMessage()); |
There was a problem hiding this comment.
Please make sure this only print out the actual error message and not the whole stack.
|
I ran your code again today (sept 4, 2024) but still got the following: 
|
|
@krasinski : Just run the command again and got the following error in one line, I save it to a file and added newline to it so I can read it and here it is:
It does not look like the error message is passed down to the user. |
|
I get to see the error message clearly at the end. Even though there are other stuff with it, I think we are done making changes here. |
wendycwong
changed the title
fix #16351