-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-16351] Do not call System.exit from water.tools [nocheck] #16366
Conversation
Your fix has stopped h2o-3 cluster from crashing. I ran the following: curl http://localhost:54321/99/Rapids --data-urlencode 'ast=(run_tool "MojoConvertTool" ["", "", "", ""])' and got the following result: From talking to @mmalohlava , he does not want to see the whole stack, just the error message which in this case is "Caused by:java.lang.IllegalArgumentException: Specified MOJO file (/Users/wendycwong/h2o-3) doesn't exist!", I took a look and think this is the file that passes everything over: RapidsHandler.java around line 38 where the whole stack errors are passed as well. |
mainInternal(args); | ||
} | ||
catch (IllegalArgumentException e) { | ||
System.err.println(e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this only print out the actual error message and not the whole stack.
@krasinski : Just run the command again and got the following error in one line, I save it to a file and added newline to it so I can read it and here it is: It does not look like the error message is passed down to the user. |
I get to see the error message clearly at the end. Even though there are other stuff with it, I think we are done making changes here. |
fix #16351