-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] GH-6769: multinomial dt yuliia #16310
base: master
Are you sure you want to change the base?
Conversation
…nto GH-6769_multinomial_DT_yuliia
h2o-algos/src/main/java/hex/tree/dt/binning/SplitStatistics.java
Outdated
Show resolved
Hide resolved
h2o-algos/src/main/java/hex/tree/dt/mrtasks/CountBinsSamplesCountsMRTask.java
Show resolved
Hide resolved
Please add to your CompressLeaf class accommodation for leave nodes that will contain an array of probabilities one for each of the multinomial class. Currently, it only takes one value for binary classification. |
I run into NPE error with this dataset: |
With this code: import sys def test_dt_multinomial():
if name == "main": |
I would like to have an basic
|
@@ -128,6 +127,7 @@ private AbstractSplittingRule findBestSplitForFeature(Histogram histogram, int f | |||
|
|||
|
|||
private static double calculateCriterionOfSplit(SplitStatistics binStatistics) { | |||
// if(binStatistics.() == 2) // todo - fix bin statistics first, they are binomial-only now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please finish those TODOs
Thank you for your work. It looks great. |
@@ -19,6 +19,7 @@ public static final class DTParametersV3 extends ModelParametersSchemaV3<DTModel | |||
"categorical_encoding", | |||
"response_column", | |||
"seed", | |||
"distribution", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wendycwong what is the idea behind the distribution here? I see that we optimize entropy in splits.. the attribute is not used in code.
#6769