Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15643: Fix wrong {in,ex}clude_explanation parameter validation #15645

Merged

Conversation

tomasfryda
Copy link
Contributor

@tomasfryda tomasfryda commented Jul 20, 2023

#15643

#15643

Validate both include_explanations and exclude_explantations.


For now it fails due to:

The associated GitHub issue #15643 must be mentioned in the description of the PR.

I tried to mention the issue both using the link and the #xxxxx but didn't seem to work, so I copy pasted the message to make sure I include correct characters because i have no other clue why this fails. Let's see if it works!

Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for it also?

Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice, otherwise LGTM! Thanks @tomasfryda.

@tomasfryda
Copy link
Contributor Author

Thanks for reminding me of this PR @maurever. I added the test.

@tomasfryda tomasfryda added this to the 3.42.0.4 milestone Oct 2, 2023
@tomasfryda tomasfryda merged commit 0ddd85f into rel-3.42.0 Oct 2, 2023
37 checks passed
@tomasfryda tomasfryda deleted the tomf_GH-15643_fix_explain_error_include_explanations branch October 2, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants