GH-15643: Fix wrong {in,ex}clude_explanation parameter validation #15645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenad1
approved these changes
Jul 25, 2023
maurever
approved these changes
Sep 21, 2023
|
Thanks for reminding me of this PR @maurever. I added the test. |
tomasfryda
deleted the
tomf_GH-15643_fix_explain_error_include_explanations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15643
#15643
Validate both include_explanations and exclude_explantations.
For now it fails due to:
I tried to mention the issue both using the link and the
#xxxxxbut didn't seem to work, so I copy pasted the message to make sure I include correct characters because i have no other clue why this fails. Let's see if it works!