Replace github.com/dgrijalva/jwt-go with github.com/golang-jwt/jwt #8939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
requested review from
klizhentas,
r0mant and
russjones
as code owners
tcsc
approved these changes
Nov 11, 2021
r0mant
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teleport currently depends on
github.com/dgrijalva/jwt-go@v3.2.0which is vulnerable to CVE-2020-26160. We do not use this library directly (it is pulled in through our dependency ongithub.com/duo-labs/webauthn/protocol), but this triggers a "high severity" dependabot security alert in the Teleport Github repo.The recommended fix is to switch to the community-maintained clone
github.com/golang-jwt/jwt.github.com/dgrijalva/jwt-gois no longer maintained and the clone is meant to be compatible while taking new fixes. There is an issue induo-labs/webauthnduo-labs/webauthn#86 to make this change, but it has been open since May 20 with no response from the maintainers.This PR uses a
replacedirective in ourgo.modto replacegithub.com/dgrijalva/jwt-go v3.2.0withgithub.com/golang-jwt/jwt v3.2.1which has the fix for the CVE.