-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pool timeout bug #38
Conversation
3278723
to
30b9bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
switching to draft until I fix these damn CI issues |
a4b6ab2
to
1a10c2f
Compare
1a10c2f
to
380b31d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn the ci
@@ -185,10 +185,12 @@ impl RadioOperator { | |||
}; | |||
} | |||
|
|||
let batch_size = 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was this size determined? would like to understand if this is a magic number or if you had some analysis on the optimal size; either way would appreciate a comment in code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic number really :> i take recommendations but it seemed like an ok batch size
count_messages
resolverprune_old_messages
more efficientcomparison_interval
tosummary_interval
to match what the function is doing a bit better, also increased the interval to 180 secondscount_messages
instead oflist_messages
in summary function