Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: epoch entity feature parity #57

Merged
merged 9 commits into from
Aug 15, 2023
Merged

feat: epoch entity feature parity #57

merged 9 commits into from
Aug 15, 2023

Conversation

sahra-karakoc
Copy link
Member

Issue link

#49

@sahra-karakoc sahra-karakoc marked this pull request as ready for review August 15, 2023 08:13
@sahra-karakoc sahra-karakoc added the type:feature New or enhanced functionality label Aug 15, 2023
@sahra-karakoc sahra-karakoc self-assigned this Aug 15, 2023
Some(epoch_count) => {
if epoch_count > BigInt::zero() {
let current_epoch = epoch_count.sub(1).to_string();
s.set_if_not_exists(1, current_epoch, &clock.number.into())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure if this is correct, as I'm not familiar with the clock logic yet, but something doesn't feel right 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled this in a meeting, the logic seems correct 👍🏼

@sahra-karakoc sahra-karakoc merged commit 4fa37f2 into main Aug 15, 2023
5 checks passed
@sahra-karakoc sahra-karakoc deleted the sahra/epoch branch August 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New or enhanced functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants