Skip to content

Commit

Permalink
Lint complaints
Browse files Browse the repository at this point in the history
  • Loading branch information
fridgepoet committed Sep 26, 2024
1 parent 3b4f321 commit 2da414b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ func TestAcc_DataSourceMetricsEndpointScrapeJob(t *testing.T) {
// Expected result: test fails and the error message should be "failed to create metrics endpoint scrape job: failed to do request"
// because the Connections API is not yet available.

t.Skip("will be enabled after Connections API is available in prod")
// t.Skip("will be enabled after Connections API is available in prod")

//testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available
// testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available
resource.ParallelTest(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
Steps: []resource.TestStep{
Expand All @@ -37,11 +37,11 @@ func TestAcc_DataSourceMetricsEndpointScrapeJob(t *testing.T) {
{
// Verifies that the created SLO Resource is read by the Datasource Read Method
// TODO: work on after other Test Step passes
//Config: testutils.TestAccExample(t, "data-sources/grafana_connections_metrics_endpoint_scrape_job/resource.tf"),
//RefreshState: true,
//Check: resource.ComposeTestCheckFunc(
// resource.TestCheckResourceAttrSet("data.grafana_connections_metrics_endpoint_scrape_job.test", "test.0.name"),
//),
// Config: testutils.TestAccExample(t, "data-sources/grafana_connections_metrics_endpoint_scrape_job/resource.tf"),
// RefreshState: true,
// Check: resource.ComposeTestCheckFunc(
// resource.TestCheckResourceAttrSet("data.grafana_connections_metrics_endpoint_scrape_job.test", "test.0.name"),
// ),
},
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) {
// Expected result: test fails and the error message should be "failed to create metrics endpoint scrape job: failed to do request"
// because the Connections API is not yet available.

//t.Skip("will be enabled after Connections API is available in prod")
// t.Skip("will be enabled after Connections API is available in prod")

//testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available
// testutils.CheckCloudInstanceTestsEnabled(t) // TODO: enable after Connections API is available
resource.ParallelTest(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
CheckDestroy: testAccMetricsEndpointCheckDestroy("test-stack-id", "my-scrape-job"),
Expand All @@ -48,7 +48,7 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) {
),
},
// TODO: work on this after "Test Create" and "CheckDestroy" pass
//{
// {
// // Tests Update
// Config: testutils.TestAccExample(t, "resources/grafana_connections_metrics_endpoint_scrape_job/resource_update.tf"),
// Check: resource.ComposeTestCheckFunc(
Expand All @@ -60,7 +60,7 @@ func TestAcc_MetricsEndpointScrapeJob(t *testing.T) {
// resource.TestCheckResourceAttr("grafana_connections_metrics_endpoint_scrape_job.test", "url", "https://www.modified-url.com:9000/metrics"),
// resource.TestCheckResourceAttr("grafana_connections_metrics_endpoint_scrape_job.test", "scrape_interval_seconds", "120"),
// ),
//},
// },
},
})
}
Expand Down

0 comments on commit 2da414b

Please sign in to comment.