task: add support for buyer option #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-gr4vy
added
minor
gryevns
reviewed
Sep 2, 2024
android/src/main/java/com/gr4vy/embedreactnative/Gr4vyActivity.java
Outdated
Show resolved
Hide resolved
gryevns
approved these changes
Sep 2, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds support for the
buyeroption when used in React Native. In the native code, instead of getting each property of the object and pass it to the structs/classes, we pass the wholeReadableMapdirectly which is decoded as the desired targetGr4vyBuyer. We useJSONSerializationin Swift andjackson(added previously) for Java.We could potentially refactor other objects (like
statementDescriptor) to use the same in the future to clean up the code. Or decide to go for json strings like we did forconnectionOptions(which will require changes in the other sdks first).Tested manually with both simulators and for different scenarios (no
buyer, no `billingDetails, etc)Ticket: https://gr4vy.atlassian.net/browse/TA-8177