fix: update insecure tar dependency #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-gr4vy
added
internal
luca-gr4vy
commented
May 7, 2024
Comment on lines
+80
to
+82
| - hermes-engine (0.71.8): | ||
| - hermes-engine/Pre-built (= 0.71.8) | ||
| - hermes-engine/Pre-built (0.71.8) |
There was a problem hiding this comment.
Last time we upgraded RN we didn't commit these lock file changes
luca-gr4vy
commented
May 7, 2024
| @@ -25,3 +25,5 @@ runs: | |||
| yarn install --cwd example --frozen-lockfile | |||
| yarn install --frozen-lockfile | |||
| shell: bash | |||
| env: | |||
| SKIP_YARN_COREPACK_CHECK: '1' | |||
There was a problem hiding this comment.
Skipping corepack check for these tasks due to this https://github.com/gr4vy/gr4vy-react-native/actions/runs/8982545520/job/24670387490?pr=26#step:3:46. We don't need to use the same exact yarn version for linting, but will probably upgrade the supported one in the future.
|
Do we have a way of testing this e2e? |
Not really, we don't have it for react native yet as it's notoriously complicated to set up |
gryevns
approved these changes
May 7, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds resolution to tar
^6.2.1, fixing the vulnerability related to it https://github.com/gr4vy/gr4vy-react-native/security/dependabot/53. Also ignores a few vulnerabilities found by trivy that are not important and can only be fixed by upgrading the project.Note: To test I had to downgrade to Xcode 14.3 (we originally set up the project with that version), as working with Xcode 15 would fail to launch the example app. We'd need to upgrade the React Native version, I created a ticket for it https://gr4vy.atlassian.net/browse/TA-6984