Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #384 - Show clustered markers in exact same location #413

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

menismu
Copy link

@menismu menismu commented Aug 3, 2017

This pull request implements a solution for a situation where more than one marker have the exact same location (lat and lng), an issue reported in #384.

The activity ClusteringSameLocationActivity shows 5 markers in the exact same location and use this new implementation. Basically, if the user does zoom in till the maximum zoom value and touch the cluster with the markers in the same location, markers are distributed in new locations based in the default implementation of ClusterItemsDistributor interface. A new distributor can be implemented and used calling ClusterManager.setClusterItemsDistributor.

There is a potential backward compatibility break as ClusterItem interface requires now a copy method to copy the cluster item with a new location to be used to distribute the markers. It is important to keep BC compatibility I could make changes to this feature or function.

This implementation requires to implement OnClusterClickListener and OnCameraMoveListener, this means if the library consumer needs to implement those listeners, it is a requirement to call to ClusterManager.handleClickListener or ClusterManager.OnCameraMove to keep the feature working well. This could be improved also if it is required.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@menismu
Copy link
Author

menismu commented Aug 3, 2017

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@menismu
Copy link
Author

menismu commented Aug 3, 2017

Added the second email as an alternative email in both Github and Gmail.

@AAverin
Copy link

AAverin commented Oct 3, 2017

Would love to have this merged. And for iOS too, ideally, because if on Android only the topmost marker is shown, in iOS google map utils markers blink =)

@stale
Copy link

stale bot commented Oct 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. label Oct 3, 2019
@jpoehnelt jpoehnelt removed the status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. label Oct 3, 2019
@jpoehnelt jpoehnelt added the triage me I really want to be triaged. label Oct 14, 2019
@barbeau barbeau changed the title Markers in exact same location Fix #384 - Show clustered markers in exact same location Nov 8, 2019
@barbeau barbeau added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Nov 8, 2019
@barbeau
Copy link
Collaborator

barbeau commented Nov 8, 2019

Closing and re-opening to try and kick-start the CLA bot...

@barbeau barbeau closed this Nov 8, 2019
@barbeau barbeau reopened this Nov 8, 2019
@jpoehnelt
Copy link
Contributor

@googlebot

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 14, 2019
@jpoehnelt
Copy link
Contributor

This needs cla from the initial commits from israel@cobaas.com.

@barbeau
Copy link
Collaborator

barbeau commented Nov 19, 2019

@menismu Is israel@cobaas.com your email? If so you'll need to configure this email with GitHub for Google's bot to recognize the CLA on file:
https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/adding-an-email-address-to-your-github-account

@arriolac arriolac changed the base branch from master to main September 14, 2021 21:12
@kikoso
Copy link
Collaborator

kikoso commented Jan 5, 2023

Hi @menismu . Did you have the chance to check the latest message regarding the CLA?

@wangela
Copy link
Member

wangela commented Feb 9, 2023

Sorry we aren't able to merge this. If you can recreate the PR from an account that you're able to sign the CLA with, feel free to propose a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants