Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added StreetViewUtil #1200

Merged
merged 4 commits into from
Aug 4, 2023
Merged

feat: added StreetViewUtil #1200

merged 4 commits into from
Aug 4, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jul 23, 2023 •
edited by wangela
Loading

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1201 🦕

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 23, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

This was referenced Jul 25, 2023
Closed
Closed
@kikoso kikoso marked this pull request as ready for review July 27, 2023 09:03
wangela
wangela requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM! Please add usage documentation to the README to explain this utility's purpose and how to use it.

wangela
wangela requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add unit tests. Thank you!

@kikoso
Copy link
Collaborator Author

kikoso commented Jul 31, 2023

The implementation LGTM! Please add usage documentation to the README to explain this utility's purpose and how to use it.

This has been added.

@kikoso
Copy link
Collaborator Author

kikoso commented Jul 31, 2023

Please also add unit tests. Thank you!

I have added three different unit tests. We could add Dagger to provide DI and a more granular testing level, but probably this suffices and we keep the library lean.

@kikoso kikoso force-pushed the feat/added_street_view_util branch from 3d2e9d4 to 4bc7a10 Compare July 31, 2023 05:17
@kikoso kikoso force-pushed the feat/added_street_view_util branch from 4bc7a10 to bab3830 Compare August 4, 2023 16:19
@wangela wangela merged commit 83f961d into main Aug 4, 2023
8 checks passed
@wangela wangela deleted the feat/added_street_view_util branch August 4, 2023 16:52
googlemaps-bot pushed a commit that referenced this pull request Aug 4, 2023
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
8ec4813 
# [3.5.0](v3.4.0...v3.5.0) (2023-08-04)

### Features

* added StreetViewUtil ([#1200](#1200)) ([83f961d](83f961d))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wangela wangela mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a utility library to check Street View availability
3 participants
@kikoso @googlemaps-bot @wangela