fix: support setting STORAGE_EMULATOR_HOST without /storage/{version} suffix #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #752 🦕
This is a draft and an attempt to fix #752.
The python client makes a request for a blob using this format (which returns an HTTP 404)
Compared to the NodeJS's implementation, which requests
The notable difference is that there's no
/storage/v1/
prefix. This is similar to the issue called out in firebase/firebase-tools#3508 (comment).Changing the base URL to a URL which the emulator can handle by following the NodeJS implementation of the
STORAGE_EMULATOR_HOST
environment variable is my attempt to fix the issue.It seems to work for getting file blobs, but does not currently work with Uploads (using the test example from #752).