chore: make StreamableQuery#internalStream package-private to avoid documentation and clirr errors on change #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duckworth/find-nearest
…duckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…duckworth/find-nearest
…duckworth/find-nearest
…ocumentation and clirr errors
…duckworth/find-nearest
product-auto-label
bot
added
size: xs
There was a problem hiding this comment.
Could we make the entire class package private?
There was a problem hiding this comment.
It's possible that customers have declared variables of this type. StreamableQuery query = firestore.collection(...).where(...). I can deprecate use of this class and remove it from the API surface in the next major release.
product-auto-label
bot
added
size: s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.