-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make StreamableQuery#internalStream package-private to avoid documentation and clirr errors on change #1896
base: main
Are you sure you want to change the base?
Conversation
…duckworth/find-nearest
…duckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…duckworth/find-nearest
…duckworth/find-nearest
…ocumentation and clirr errors
…duckworth/find-nearest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make the entire class package private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that customers have declared variables of this type. StreamableQuery query = firestore.collection(...).where(...)
. I can deprecate use of this class and remove it from the API surface in the next major release.
No description provided.