Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Logging] Add resource labels to logs from Cloud Run #7642

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kynx
Copy link
Contributor

@kynx kynx commented Sep 4, 2024

Fixes #3699

I've tried to match the labels and resource sections output when logging to stdout as closely as possible. The one thing missing is labels.container_name - I can't figure out where to get that value from.

@kynx kynx requested review from a team as code owners September 4, 2024 17:13
Copy link

google-cla bot commented Sep 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kynx
Copy link
Contributor Author

kynx commented Sep 17, 2024

@bshaffer Any chance of a review? Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logging] Resource type and other metadata not auto-populated on Cloud Run
1 participant