-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA event tracking for the No Audiences Banner and Info Notice #9550
base: develop
Are you sure you want to change the base?
Add GA event tracking for the No Audiences Banner and Info Notice #9550
Conversation
…s to the No Audiences Banner.
…` GA events in the No Audiences Banner.
Build files for a7d7127 are ready:
|
Size Change: +2.18 kB (+0.12%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
} ) ) | ||
) | ||
); | ||
if ( configuredAudiences.length > 0 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a minor bug, calling setExpirableItemTimers()
with an empty list results in an error being returned and logged to the console.
); | ||
} | ||
|
||
return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an error that occurs when attempting to destructure the return value of the action.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist